Skip to content

Fix checking nested fields for records #18964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix checking nested fields for records #18964

wants to merge 5 commits into from
+79 −7

Conversation

evgTSV
Copy link
Contributor

@evgTSV evgTSV commented Oct 3, 2025 •
edited
Loading

Enhance the F# compiler’s type checker to correctly support and validate nested field updates (with depth > 1) for both anonymous and records. Add tests to cover these scenarios, and perform minor refactoring.

Fixes #18940
Fixes #18062

@evgTSV evgTSV requested a review from a team as a code owner October 3, 2025 20:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025 •
edited
Loading

❗ Release notes required

@evgTSV,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/11.0.0.md No release notes found or release notes format is not correct

auduchinok
auduchinok reviewed Oct 3, 2025
View reviewed changes
@evgTSV evgTSV requested a review from auduchinok October 4, 2025 12:11
@edgarfgp
Copy link
Contributor

edgarfgp commented Oct 5, 2025

I think this might also fix #18062 ?

@evgTSV
Copy link
Contributor Author

evgTSV commented Oct 5, 2025

Yes, this fixes that issue too

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Oct 13, 2025
@T-Gro T-Gro enabled auto-merge (squash) October 13, 2025 08:53
kerams
kerams reviewed Oct 13, 2025
View reviewed changes
edgarfgp
edgarfgp reviewed Oct 13, 2025
View reviewed changes
vzarytovskii
vzarytovskii reviewed Oct 13, 2025
View reviewed changes
vzarytovskii
vzarytovskii reviewed Oct 13, 2025
View reviewed changes
auto-merge was automatically disabled October 14, 2025 14:57

Head branch was pushed to by a user without write access

@evgTSV evgTSV requested review from T-Gro and vzarytovskii October 14, 2025 14:57
@edgarfgp
Copy link
Contributor

/run fantomas

@github-actions GitHub Actions
Copy link
Contributor

🔧 CLI Command Report

  • Command: /run fantomas
  • Outcome: success

✅ Patch applied:
- Files changed: 2
- Lines changed: 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

@auduchinok auduchinok Awaiting requested review from auduchinok

@vzarytovskii vzarytovskii Awaiting requested review from vzarytovskii

+2 more reviewers

@kerams kerams kerams left review comments

@edgarfgp edgarfgp edgarfgp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nested field update doesn't type-check properly Copy and update record expression doesn't compile when the record comes from a function

6 participants

@evgTSV @edgarfgp @vzarytovskii @auduchinok @kerams @T-Gro